Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Starter Kits list #2

Merged
merged 1 commit into from
Mar 16, 2016
Merged

Update the Starter Kits list #2

merged 1 commit into from
Mar 16, 2016

Conversation

lvarayut
Copy link
Contributor

@lvarayut lvarayut commented Mar 3, 2016

I added a relay-fullstack project to the starter kits list.

@@ -86,6 +86,7 @@ Awesome resources for [Relay](https://github.com/facebook/relay), based on the [
- [Relay Skeleton](https://github.com/fortruce/relay-skeleton) - React, Relay, GraphQL project skeleton.
- [Relay Starter Kit](https://github.com/relayjs/relay-starter-kit) - An app that it already set up with a basic setup. Just clone and tweak to suit your needs!
- [Simple Relay Starter](https://github.com/mhart/simple-relay-starter) - A Browserify version of the [Relay Starter Kit](https://github.com/relayjs/relay-starter-kit).
- [Relay Fullstack](https://github.com/lvarayut/relay-fullstack) - Relay Starter Kit integrated with Relay, GraphQL, Express, ES6/ES7, JSX, Webpack, Babel, Material Design Lite, and PostCSS.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super nit-picky, but some of this stuff can be assumed. Relay requires GraphQL, for instance. I'm open to the current version, but how about something along the lines of:

The Relay Starter Kit, integrated with Relay, Express, Material Design Lite, PostCSS, Babel, and built with Webpack

@expede
Copy link
Owner

expede commented Mar 12, 2016

Nice kit! Just the one thought, but I'm giving this a 👍 Let me know when you're happy to have it merged, @lvarayut

@lvarayut
Copy link
Contributor Author

Thanks for your feedback. Even though, Relay requires GraphQL in the current version, however, the developer team is working on extending to provide an interface to interact with in-memory and native device data as well. Here is the long discussion and also mentioned in the official website.

Relay and React could also be written using any programming languages, such as TypeScript, and JSX is totally optional.

That's why I would like to explicitly mention all of them in order to make it clear.

@expede
Copy link
Owner

expede commented Mar 13, 2016

@lvarayut Thanks for the links 😄 It looks like most of the proposed solutions involve GraphQL (or at least a GQL-compatible syntax). Such changes are uncertain enough that I think that we should cross that bridge once the changes are finalized, but I'm not really that fussed by it. I'm still a little weary of listing all of the internal packages, as if those change, we'll have to keep updating the description in this repo, which could be easy to forget.

All of that said, I also don't want this to turn into a bike shed 🚲🏠. If you rebase away the merge conflicts, I'll merge the PR. Just let me know when it's good to go! 😄

@lvarayut
Copy link
Contributor Author

I modified it as you suggested.

@expede
Copy link
Owner

expede commented Mar 16, 2016

@lvarayut awesome; thanks 😄

Also, thanks for creating Relay Fullstack: it's going to save me a lot of time 🎉👍

expede added a commit that referenced this pull request Mar 16, 2016
Update the Starter Kits list
@expede expede merged commit 62061ff into expede:master Mar 16, 2016
@lvarayut
Copy link
Contributor Author

Thanks for merging and glad you ❤️ it. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants