Ruff/b023 (#203)

* update toml * fix b023 issue * simplified default args, fixed install docs, added version.py to gitignore --------- Co-authored-by: Behrang Shafei <[email protected]>
experimental-design · May 13, 2023 · 3d7b300 · 3d7b300
1 parent 0e17c98
commit 3d7b300
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -130,3 +130,6 @@ dmypy.json
 
 # Pyre type checker
 .pyre/
+
+# generated version file
+bofire/version.py
diff --git a/docs/install.md b/docs/install.md
@@ -39,5 +39,5 @@ git clone https://github.com/experimental-design/bofire.git
 ```
 and cd `bofire`, you can proceed with
 ```
-pip install -e .[optimization,cheminfo,docs,testing]
+pip install -e .[optimization,cheminfo,docs,tests]
 ```
diff --git a/pyproject.toml b/pyproject.toml
@@ -10,7 +10,6 @@ ignore = [
     "E501",  # don't enforce for comments and docstrings
     "B017",  # required for tests
     "B027",  # required for optional _tell method
-    "B023",
     "B028",
     "B904",
     "B905"

diff --git a/tests/bofire/data_models/specs/specs.py b/tests/bofire/data_models/specs/specs.py
@@ -54,7 +54,7 @@ def invalidate(self, spec: Spec) -> List[Spec]:
         if self.key not in data:
             return []
         return [
-            Spec(spec.cls, lambda: {**data, **overwrite})
+            Spec(spec.cls, lambda data=data, overwrite=overwrite: {**data, **overwrite})
             for overwrite in self.overwrites
         ]
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,7 +10,6 @@ ignore = [ @@
         "E501",  # don't enforce for comments and docstrings
         "B017",  # required for tests
         "B027",  # required for optional _tell method
-        "B023",
         "B028",
         "B904",
         "B905"
@@ Expand Down @@