286 add surrogate models that can extrapolate #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dlinzner-bcs
commented
Oct 10, 2023
dlinzner-bcs
commented
- again the stupid bug that the surrogate has to be allowed for BotochSurrogate
|
@bertiqwerty the test is there :) can you please check? |
dlinzner-bcs
added a commit
that referenced
this pull request
Oct 20, 2023
* add polynomial kernel * add polynomial kernel * add polynomial kernel * add polynomial kernel * add quadratic surrogate * adding linear kernel not necessary * adding linear kernel not necessary * adding linear kernel not necessary * fix test * change kernel tzpe hint * generalize quadratic surrogate * generalize quadratic surrogate * generalize quadratic surrogate * fix init * fix init * fix init * fix init * fix init * add polynomial_surrogate to AnyBotochSurrogate * add test that botorch surrogate can be composed * add test that botorch surrogate can be composed * add test that botorch surrogate can be composed * add test that botorch surrogate can be composed * add test that botorch surrogate can be composed
dlinzner-bcs
added a commit
that referenced
this pull request
Oct 23, 2023
* add polynomial kernel * add polynomial kernel * add polynomial kernel * add polynomial kernel * add quadratic surrogate * adding linear kernel not necessary * adding linear kernel not necessary * adding linear kernel not necessary * fix test * change kernel tzpe hint * generalize quadratic surrogate * generalize quadratic surrogate * generalize quadratic surrogate * fix init * fix init * fix init * fix init * fix init * add polynomial_surrogate to AnyBotochSurrogate * add test that botorch surrogate can be composed * add test that botorch surrogate can be composed * add test that botorch surrogate can be composed * add test that botorch surrogate can be composed * add test that botorch surrogate can be composed * added test for iterative strategy * added iterative strategy * 286 add surrogate models that can extrapolate (#300) (#303) * add polynomial kernel * add polynomial kernel * add polynomial kernel * add polynomial kernel * add quadratic surrogate * adding linear kernel not necessary * adding linear kernel not necessary * adding linear kernel not necessary * fix test * change kernel tzpe hint * generalize quadratic surrogate * generalize quadratic surrogate * generalize quadratic surrogate * fix init * fix init * fix init * fix init * fix init * add polynomial_surrogate to AnyBotochSurrogate * add test that botorch surrogate can be composed * add test that botorch surrogate can be composed * add test that botorch surrogate can be composed * add test that botorch surrogate can be composed * add test that botorch surrogate can be composed * rmv unneccessary private flagged variables * made strategy selection clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.