Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Botorch 0.9.5 #317

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Botorch 0.9.5 #317

merged 2 commits into from
Dec 11, 2023

Conversation

jduerholt
Copy link
Contributor

@jduerholt jduerholt commented Dec 11, 2023

BoTorch version 0.9.5 was released yesterday. It features the possibility to use q>1 for nonlinear constraints which is very helpful for us due to how NChooseK constraints are implemented in the BO part of BoFire. This PR sets the min required BoTorch version for BoFire to 0.9.5.

In addition, the following two bugs are fixed:

  • Rounding of continuous inputs was only working for series of length 3.
  • The random seed was not set correctly set in the polytope sampler.

After this PR is merged in, a new release for BoFire will be filed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@bertiqwerty
Copy link
Contributor

Thanks Johannes. I left one minor comment.

bofire/data_models/features/continuous.py Outdated Show resolved Hide resolved

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@jduerholt jduerholt merged commit d4c5c49 into main Dec 11, 2023
10 checks passed
@jduerholt jduerholt deleted the feature/botorch0.9.5 branch December 11, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants