-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement batch constraint for doe #324
Conversation
Oh I did not see that one. Sorry, I thought we agreed we would do the doe constraint after you do the polytope sampler and interpoint constraint, but I might as well missunderstood that. Anyways, I am fine with proceeding with Aaron's implementation, since I am still playing around with a formating that would make pyright and black to not complain. |
@KappatC Ah, yes this is possible. Sorry in that case! Was working on the batch constraints this weekend anyways and just continued bc I was already on it... |
@Osburg nw, thanks for working on this in any case. Maybe in the future we just try to coordinate a bit better, so that we don't do duplicate work |
So, we close this PR and go forward with the one from @Osburg? |
@jduerholt sure, let me play a bit around it first and then I ll close it |
yes, sure, this was my bad! Will watch out better next time! |
closing due to duplicate with #322 |
No description provided.