Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement batch constraint for doe #324

Closed
wants to merge 12 commits into from
Closed

Conversation

KappatC
Copy link
Collaborator

@KappatC KappatC commented Dec 18, 2023

No description provided.

@KappatC KappatC linked an issue Dec 18, 2023 that may be closed by this pull request
@jduerholt
Copy link
Contributor

@Osburg did the same here: #322

So with which solution should we go on?

@KappatC
Copy link
Collaborator Author

KappatC commented Dec 18, 2023

@Osburg did the same here: #322

So with which solution should we go on?

Oh I did not see that one. Sorry, I thought we agreed we would do the doe constraint after you do the polytope sampler and interpoint constraint, but I might as well missunderstood that. Anyways, I am fine with proceeding with Aaron's implementation, since I am still playing around with a formating that would make pyright and black to not complain.

@Osburg
Copy link
Collaborator

Osburg commented Dec 18, 2023

@KappatC Ah, yes this is possible. Sorry in that case! Was working on the batch constraints this weekend anyways and just continued bc I was already on it...

@KappatC
Copy link
Collaborator Author

KappatC commented Dec 18, 2023

@Osburg nw, thanks for working on this in any case. Maybe in the future we just try to coordinate a bit better, so that we don't do duplicate work

@jduerholt
Copy link
Contributor

So, we close this PR and go forward with the one from @Osburg?

@KappatC
Copy link
Collaborator Author

KappatC commented Dec 18, 2023

@jduerholt sure, let me play a bit around it first and then I ll close it

@Osburg
Copy link
Collaborator

Osburg commented Dec 18, 2023

@Osburg nw, thanks for working on this in any case. Maybe in the future we just try to coordinate a bit better, so that we don't do duplicate work

yes, sure, this was my bad! Will watch out better next time!

Chrysoula Kappatou added 2 commits December 18, 2023 14:50
@KappatC
Copy link
Collaborator Author

KappatC commented Dec 18, 2023

closing due to duplicate with #322

@KappatC KappatC closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch constraint for DoE
3 participants