Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make candidate_count enforcement less strict #492

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

jduerholt
Copy link
Contributor

This PR makes the candidate_count enforcement less strict:

  • A warning instead of an error is raised if the strategy spits out more candidates than expected. This was also requested by @CompRhys
  • In the FractionalFactorialStrategy also values despite None for candidate count are allowed, nevertheless it always returns the predefined number of candidates and ignore the value given for candidate_count.

@jduerholt jduerholt requested a review from bertiqwerty January 7, 2025 11:15
Copy link
Contributor

@bertiqwerty bertiqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Agreed.

@bertiqwerty
Copy link
Contributor

Thanks. Agreed.

Actually, I wanted to respond this to the other PR but it also fits here.

@jduerholt jduerholt merged commit e560833 into main Jan 14, 2025
7 of 9 checks passed
@jduerholt jduerholt deleted the hotfix/fractional_factorial branch January 14, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants