Add StaticVectors.v1 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is all extraordinarily displeasing. |
adrianeboyd
force-pushed
the
feature/add-static-vectors-v1
branch
from
4603a01 to
9383a4d
Compare
adrianeboyd
added a commit
to adrianeboyd/spaCy
that referenced
this pull request
Apr 12, 2021
* Increase versions of all architctures and layers related to `StaticVectors` * Improve efficiency of 0-vector operations Parallel `spacy-legacy` PR: explosion/spacy-legacy#5
3 tasks
For tok2vec, freeze the implementations by retrieving all layers and architectures from the registry instead of importing from `thinc` or `spacy`.
|
I am now slightly less displeased, but kind of wish that |
honnibal
pushed a commit
to explosion/spaCy
that referenced
this pull request
Apr 22, 2021
* Replace negative rows with 0 in StaticVectors Replace negative row indices with 0-vectors in `StaticVectors`. * Increase versions related to StaticVectors * Increase versions of all architctures and layers related to `StaticVectors` * Improve efficiency of 0-vector operations Parallel `spacy-legacy` PR: explosion/spacy-legacy#5 * Update config defaults to new versions * Update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a companion PR to explosion/spaCy#7674, add:
spacy-legacy.StaticVectors.v1spacy-legacy.HashEmbedCNN.v1spacy-legacy.MultiHashEmbed.v1spacy-legacy.CharacterEmbed.v1Bump
spacy-legacyversion tov3.0.3.