Fix path coercion for pathlib-like interfaces (Pathy) #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pathy inherited from
pathlib.Path
, so this always worked for saving spaCy models, but a new Pathy version that supports Python 3.12 will not inherit frompathlib.Path
so this check fails and model saving goes with it.Someone pointed out that the spaCy contributing doc specifies how things should work.
I don't know if that extends to srsly, but I would think so.
There's more context on the Pathy 3.12 issue: justindujardin/pathy#106 (comment)