Skip to content

Commit

Permalink
[chore] Upgrade ESLint (#499)
Browse files Browse the repository at this point in the history
# Why

I've been having issues with VS Code complaining rules for `@typescript-eslint/no-throw-literal` and `.../ban-types` were missing.

# How

I've decided to try upgrading ESLint config. So far so good.

# Test Plan

CI should be green.
  • Loading branch information
sjchmiela authored Jan 22, 2025
1 parent ae3001b commit 4d9a65a
Show file tree
Hide file tree
Showing 3 changed files with 849 additions and 364 deletions.
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
},
"devDependencies": {
"@types/node": "20.14.2",
"eslint": "8.56.0",
"eslint-config-universe": "13.0.0",
"eslint-plugin-import": "2.29.1",
"eslint-plugin-jest": "28.6.0",
"eslint": "^8.57.1",
"eslint-config-universe": "14.0.0",
"eslint-plugin-import": "2.31.0",
"eslint-plugin-jest": "28.11.0",
"lerna": "^7.1.4",
"prettier": "3.3.1",
"typescript": "5.4.5"
Expand Down
2 changes: 1 addition & 1 deletion packages/steps/src/__tests__/BuildStep-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ describe(BuildStep, () => {
],
command,
});
const error = await getErrorAsync<BuildStepRuntimeError>(async () => step.executeAsync());
const error = await getErrorAsync<BuildStepRuntimeError>(() => step.executeAsync());
expect(error).toBeInstanceOf(BuildStepRuntimeError);
expect(error.message).toMatch(/Some required outputs have not been set: "abc"/);
});
Expand Down
Loading

0 comments on commit 4d9a65a

Please sign in to comment.