[build-tools] skip throwing MAVEN_CACHE_ERROR if Could not find BlurView-version-2.0.3.jar line is present #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew-version-2.0.3.jar line is present
This stack of pull requests is managed by Graphite. Learn more about stacking. |
radoslawkrzemien
approved these changes
Jan 27, 2025
| @@ -299,7 +299,11 @@ export const buildErrorHandlers: ErrorHandler<TrackedBuildError>[] = [ | |||
| phase: BuildPhase.RUN_GRADLEW, | |||
| regexp: ({ env }: ErrorContext) => | |||
| env.EAS_BUILD_MAVEN_CACHE_URL | |||
| ? new RegExp(escapeRegExp(env.EAS_BUILD_MAVEN_CACHE_URL)) | |||
| ? new RegExp( | |||
There was a problem hiding this comment.
Maybe it would be worth it to add a comment with context for this regex
szdziedzic
deleted the
01-27-_build-tools_skip_throwing_maven_cache_error_if_could_not_find_blurview-version-2.0.3.jar_line_is_present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
These alerts are getting way too noisy. All of these are false positives. This
BlurViewpackage in this version was just deleted from jitpack.How
Don't throw
MAVEN_CACHE_ERRORif theCould not find BlurView-version-2.0.3.jarline is present in logsTest Plan
Tests