Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build-tools] fix test fixtures #508

Merged
merged 2 commits into from
Feb 3, 2025
Merged

[build-tools] fix test fixtures #508

merged 2 commits into from
Feb 3, 2025

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Feb 3, 2025 •
edited
Loading

Why

Previous fixtures expired

How

Use fresh data

Test Plan

Tests

@szdziedzic Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic marked this pull request as ready for review February 3, 2025 15:59
@szdziedzic szdziedzic requested a review from sjchmiela as a code owner February 3, 2025 15:59
@khamilowicz khamilowicz self-requested a review February 3, 2025 16:07
khamilowicz
khamilowicz requested changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@khamilowicz khamilowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail

@szdziedzic Graphite App
Copy link
Member Author

szdziedzic commented Feb 3, 2025 •
edited
Loading

Merge activity

  • Feb 3, 11:28 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 3, 11:28 AM EST: A user merged this pull request with Graphite.

@szdziedzic szdziedzic merged commit 63243f1 into main Feb 3, 2025
5 checks passed
@szdziedzic szdziedzic deleted the 02-03-_build-tools_fix_test_fixtures branch February 3, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjchmiela sjchmiela sjchmiela approved these changes

@khamilowicz khamilowicz khamilowicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szdziedzic @sjchmiela @khamilowicz