-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli][eas-update] Change behavior of roll-back-to-embedded to not use current project state #2722
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Size Change: -966 B (0%) Total Size: 52.6 MB
|
c6c0de0
to
d492c71
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2722 +/- ##
==========================================
- Coverage 52.74% 52.74% -0.00%
==========================================
Files 580 580
Lines 22283 22277 -6
Branches 4358 4355 -3
==========================================
- Hits 11751 11747 -4
+ Misses 10496 10495 -1
+ Partials 36 35 -1 ☔ View full report in Codecov by Sentry. |
… use current project state
d492c71
to
3e4925b
Compare
✅ Thank you for adding the changelog entry! |
Subscribed to pull request
Generated by CodeMention |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! 🙏
Why
After discussion with @quinlanj about whether fingerprints should be taken during roll-back-to-embedded publish, we realized that this command actually probably shouldn't rely on the current state of the project in the current working directory for anything (except code signing, but that's an edge case).
The reason for this is that one shouldn't have to check out a release branch to publish the roll-back-to-embedded directive since fingerprint might differ if branch is stale and deps change under the hood, thus making it impossible to issue the directive for the desired binary (rtv).
Closes ENG-14282.
How
Make this behave more like a rollout or roll-back-to-embedded on the website: ask for all info rather than gathering it from the current working directory.
Test Plan
Run test.
Manual test: