Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli][eas-update] Change behavior of roll-back-to-embedded to not use current project state #2722

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Nov 22, 2024

Why

After discussion with @quinlanj about whether fingerprints should be taken during roll-back-to-embedded publish, we realized that this command actually probably shouldn't rely on the current state of the project in the current working directory for anything (except code signing, but that's an edge case).

The reason for this is that one shouldn't have to check out a release branch to publish the roll-back-to-embedded directive since fingerprint might differ if branch is stale and deps change under the hood, thus making it impossible to issue the directive for the desired binary (rtv).

Closes ENG-14282.

How

Make this behave more like a rollout or roll-back-to-embedded on the website: ask for all info rather than gathering it from the current working directory.

Test Plan

Run test.

Manual test:

$ neas update:roll-back-to-embedded
★ [email protected] is now available.
To upgrade, run npm install -g eas-cli.
Proceeding with outdated version.

✔ Which branch would you like to use? › main - current update: "Republish "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce non enim nulla. Praesent turpis massa, imperdiet et imperdiet quis, semper id nisl. Pellentesque ut ex consectetur, maximus nisl vel, vehicula ipsum. Vestibulum facilisis arcu nec rhoncus lacinia. Proin dignissim libero vitae porttitor lacinia. Duis quis risus id dui accumsan interdum sollicitudin id odio. Nam tincidunt malesuada interdum. Aliquam ac auctor odio. Nam sit amet rhoncus lorem. Donec venenatis ipsum nibh, a pellentesqu..." (2 weeks ago by wschurman)
✔ Provide an update message: … Initial commit

Generated by create-expo-app 3.0.0.
✔ Select a target runtime › 1.0.0
✔ Published!

Branch             main
Runtime version    1.0.0
Platform           android, ios
Update group ID    302acb22-656c-4b0e-9706-6f08d21cebd8
Android update ID  34ea2160-3fd9-4663-92bb-f2128197fd69
iOS update ID      98aa58e7-40e0-42d7-925d-2d284800932f
Message            Initial commit

Copy link
Member Author

Copy link

linear bot commented Nov 22, 2024

Copy link

github-actions bot commented Nov 22, 2024

Size Change: -966 B (0%)

Total Size: 52.6 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.6 MB -966 B (0%)

compressed-size-action

@wschurman wschurman force-pushed the @wschurman/11-22-_eas-cli_eas-update_change_behavior_of_roll-back-to-embedded_to_not_use_current_project_state branch from c6c0de0 to d492c71 Compare November 25, 2024 17:48
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 37.20930% with 27 lines in your changes missing coverage. Please review.

Project coverage is 52.74%. Comparing base (48ebd9b) to head (3e4925b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...s-cli/src/commands/update/roll-back-to-embedded.ts 47.37% 10 Missing ⚠️
...ges/eas-cli/src/rollout/actions/RolloutMainMenu.ts 0.00% 4 Missing ⚠️
...s-cli/src/rollout/actions/NonInteractiveRollout.ts 0.00% 3 Missing ⚠️
packages/eas-cli/src/branch/queries.ts 50.00% 2 Missing ⚠️
...kages/eas-cli/src/rollout/actions/CreateRollout.ts 0.00% 2 Missing ⚠️
packages/eas-cli/src/rollout/actions/EndRollout.ts 0.00% 2 Missing ⚠️
...kages/eas-cli/src/rollout/actions/ManageRollout.ts 0.00% 2 Missing ⚠️
...FromChannelNameAndCreateAndLinkIfNotExistsAsync.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2722      +/-   ##
==========================================
- Coverage   52.74%   52.74%   -0.00%     
==========================================
  Files         580      580              
  Lines       22283    22277       -6     
  Branches     4358     4355       -3     
==========================================
- Hits        11751    11747       -4     
+ Misses      10496    10495       -1     
+ Partials       36       35       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wschurman wschurman force-pushed the @wschurman/11-22-_eas-cli_eas-update_change_behavior_of_roll-back-to-embedded_to_not_use_current_project_state branch from d492c71 to 3e4925b Compare November 25, 2024 18:02
@wschurman wschurman changed the title [eas-cli[eas-update] Change behavior of roll-back-to-embedded to not use current project state [eas-cli][eas-update] Change behavior of roll-back-to-embedded to not use current project state Nov 25, 2024
@wschurman wschurman marked this pull request as ready for review November 25, 2024 18:02
Copy link

✅ Thank you for adding the changelog entry!

@wschurman wschurman requested a review from quinlanj November 25, 2024 18:02
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-cli/src/update/** @EvanBacon, @byCedric
packages/eas-cli/src/commands/update/** @EvanBacon, @byCedric

Generated by CodeMention

Copy link
Member

@quinlanj quinlanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🙏

@wschurman wschurman merged commit db7461a into main Nov 25, 2024
12 checks passed
@wschurman wschurman deleted the @wschurman/11-22-_eas-cli_eas-update_change_behavior_of_roll-back-to-embedded_to_not_use_current_project_state branch November 25, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants