Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Add environment flag to deploy script #2763

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

kadikraman
Copy link
Contributor

Why

The --environment flag was getting sanitised out of the flags so it was always undefined.

How

Added the environment flag to sanitizeFlags.
Also switched to using the shared EASEnvironmentFlag which does additional validation and transforms the flag to uppercase.

Test Plan

Tested locally that easd deploy --environment production includes env vars in api routes.

Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Dec 11, 2024

Size Change: +1.5 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +1.5 kB (0%)

compressed-size-action

@kadikraman kadikraman force-pushed the @kadikraman/worker-env-flag branch from 427ba1d to e0a39a0 Compare December 11, 2024 16:21
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.50%. Comparing base (17661d1) to head (bfd7444).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2763   +/-   ##
=======================================
  Coverage   52.50%   52.50%           
=======================================
  Files         583      583           
  Lines       22583    22583           
  Branches     4449     4449           
=======================================
  Hits        11854    11854           
  Misses      10694    10694           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✅ Thank you for adding the changelog entry!

@kadikraman kadikraman merged commit bc282b6 into main Dec 11, 2024
7 checks passed
@kadikraman kadikraman deleted the @kadikraman/worker-env-flag branch December 11, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants