-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Combine .env
and EAS environment variables for deploy
command
#2783
[eas-cli] Combine .env
and EAS environment variables for deploy
command
#2783
Conversation
Subscribed to pull request
Generated by CodeMention |
c6eb6e7
to
04a5671
Compare
Size Change: -249 B (0%) Total Size: 53.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2783 +/- ##
==========================================
- Coverage 52.52% 52.50% -0.01%
==========================================
Files 583 583
Lines 22589 22595 +6
Branches 4452 4454 +2
==========================================
Hits 11862 11862
- Misses 10692 10698 +6
Partials 35 35 ☔ View full report in Codecov by Sentry. |
18ea25b
to
0be4a4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question for discussion: should this be the behavior for all commands that accept an --environment
flag? (update
, etc)
@kitten Oh okay I think this merging can actually work. You just need to always use One more thing that remains is that this logic would be different from how
I'm not saying this is necessarily bad I just want to make you aware of it. Why do I think this can possibly be confusing? We have 2 commands that work really similarly ( |
EAS Build is tricky here because in 50% of the cases people have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discussed things https://exponent-internal.slack.com/archives/C9PRD479V/p1736172771062909 with @byCedric and it seems reasonable to me 🚀 thanks 🙏
@szdziedzic @byCedric: Switched over to the new |
c421ad2
to
ccdabb2
Compare
Co-authored-by: Kadi Kraman <[email protected]>
✅ Thank you for adding the changelog entry! |
Why
This allows
--environment
to be combined with local.env
files, outputting a warning when any variables conflict since EAS environment variables will take precedence.How
createManifestAsync
to returnmanifest
and conflicting variable namesgetEnv
and merge variables into theenv
objectTest Plan