Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use inputs metadata key #49

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Conversation

bradbyte
Copy link

@bradbyte bradbyte commented May 29, 2020

Additional context

A warning is thrown while using the action that the inputs are not valid. This is a simple fix by using the correct metadata key (see https://help.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#inputs).
image

@davesnx
Copy link

davesnx commented May 29, 2020

Good catch @bradbumbalough, I was going crazy with the warning and the secrets being passed correctly.

@byCedric
Copy link
Member

byCedric commented Jun 10, 2020

Ah, that's a good one! I'm sorry for this, LGTM 😄 This is released with 5.1.1 or v5 🚀

@byCedric byCedric merged commit 71dfeab into expo:master Jun 10, 2020
@bradbyte bradbyte deleted the fix/inputs-warning branch June 10, 2020 18:21
@byCedric
Copy link
Member

Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants