Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qs dependency to 6.3.0 #215

Closed
wants to merge 6 commits into from
Closed

Update qs dependency to 6.3.0 #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f5ac15d
Update qs dependency to 6.3.0
ysangkok Dec 21, 2016
3428e44
add debug/iconv-lite/qs dep updates
ysangkok Dec 21, 2016
d521790
Upgrade debug and iconv-lite
ysangkok Dec 21, 2016
d9ba036
Add missing tilde in debug version
ysangkok Dec 21, 2016
8b2f8b8
undo upgrading of debug and iconv-lite
ysangkok Dec 21, 2016
85bd533
More details on qs changes
ysangkok Dec 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
1.15.3 / 2016-12-xx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be "unreleased" you can use past commits to see how that is done until we have docs on the process.

===================

* deps: [email protected]
- Date stringification format configurable (https://github.com/ljharb/qs/issues/159)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use the stringification API, so this is an irrelevant change to our users. Please only list the changes that affect our users.

- RFC 1738 support (`+` instead of `%20`). Must be explicitly enabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a change in parsing or stringification?

- For remaining changes, see [qs/CHANGELOG.md](https://github.com/ljharb/qs/blob/master/CHANGELOG.md#630)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the purpose of adding the information here is specifically so no one ever has to go reference the dependency change log :) I would remove this.


1.15.2 / 2016-06-19
===================

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"http-errors": "~1.5.0",
"iconv-lite": "0.4.13",
"on-finished": "~2.3.0",
"qs": "6.2.0",
"qs": "6.3.0",
"raw-body": "~2.1.7",
"type-is": "~1.6.13"
},
Expand Down