Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: updated github actions ci workflow #6314

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

Phillip9587
Copy link
Contributor

I noticed that the current CI workflow in this repository could benefit from some updates. Specifically:

  1. Deprecation of Artifact Actions v3:

    • The actions/upload-artifact@v3 and actions/download-artifact@v3 actions are being deprecated as of November 30, 2024 (GitHub Deprecation Notice).
    • These actions should be updated to their latest versions to ensure continued functionality in the CI workflow.
    • CI Runs are currently failing like in PR chore(deps): update debug to ^4.4.0 #6313
  2. The Coverage setup could also be optimized:

    • Currently, the workflow uses the coverallsapp/github-action@master which points to v1 of this action. This v1 action uses node16 as runtime which is deprecated.
  3. Minimum token permissions for the GITHUB_TOKEN:

  4. lint step install only dev dependencies

@UlisesGascon
Copy link
Member

I will merge this PR as currently has a fix for our broken CI (example)

Screenshot from 2025-02-05 13-26-26

@UlisesGascon UlisesGascon merged commit a5cb681 into expressjs:master Feb 5, 2025
21 checks passed
@UlisesGascon
Copy link
Member

@Phillip9587 do you mind to port this to 4.x branch too? Seems like the CI is broken too (ref) :)

Phillip9587 added a commit to Phillip9587/express that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants