-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy 5x documentation files #1037
Conversation
Hey @RamirezAlex, good work on getting this started! I think we probably want to start by pulling this into a Also @RamirezAlex, just because no one has commented doesn't mean it has been ignored. @crandmck is one of the thumbs up, and he is the primary contact for maintaining this. It just takes time to get to all the PR's and work being done in Express :) |
Sorry I've been MIA for a bit... I think it will be easier if people can see how the 5.x docs are evolving, i.e. not in a branch--which wouldn't be visible on the site, only on GH (or if you built and ran the branch locally on Jekyll). This PR adds the API docs under "5.x RC": Assuming "RC" is the right rubric, I think we can land this and take it from there. One small gotcha: Since this PR was opened, 4.17 was released with a couple new functions - see #1043 ... So, we'll just need to add those updates. IMO it could be done in this PR (best), or even after merging (as long as we don't forget!). Thoughts? |
Currently 5.x is alpha, so it should probably note alpha in the heading. And I agree with landing it on master to make it available on the site as it's being worked on -- just it's existence should help provide exposure to usage more than it's getting now. |
Cool... So, @RamirezAlex if you would change the heading to |
Thank you all for the guidance here. So, @crandmck I changed the heading to |
Ignore it @crandmck, I found out that StandardJS was recently added, so I applied the fixes accordingly. :) |
Thank you for all the feedback @crandmck, I already applied the changes so when you have a chance please review it and let me know whether there are next steps or this is Ok. |
@RamirezAlex Sorry for the delay. I will try to review this in the next day or so. |
Thanks for the contribution, @RamirezAlex ! |
This is related to: expressjs/express#3913
Includes:
en/4x
-->en/5x
_includes/api/4x
-->_includes/api/5x
_layouts/4x-api.html
-->_layouts/5x-api.html
header/header-en.html
to 5.x (RC) documentation@dougwilson Could you please review and also provide me with more information or examples of what should edit on the entries related to the change log (https://github.com/expressjs/express/blob/5.0/History.md) ? Thank you.