Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: Do not extend Block from deprecated parents #49

Open
jissereitsma opened this issue Jul 14, 2018 · 1 comment
Open

Rule: Do not extend Block from deprecated parents #49

jissereitsma opened this issue Jul 14, 2018 · 1 comment
Assignees
Labels
accepted This rule is accepted by extdn

Comments

@jissereitsma
Copy link
Contributor

jissereitsma commented Jul 14, 2018

A rule should check whether a Block is extending upon Magento\Backend\Block\Widget\Form\Generic and Magento\Backend\Block\Widget\Grid\Container (and possibly others) which are deprecated. The rule should respond that a UiComponent should be created instead.

Rule

The classes Magento\Backend\Block\Widget\Form\Generic and Magento\Backend\Block\Widget\Grid\Container are deprecated since Magento_Backend version 100.2.0 (so more or less Magento 2.2). Instead, UiComponents should be used.

Reason

Only with UiComponent, other people can easily add custom uiComponent XML to extend upon the original form. Even though creating UiComponents might be hard, using them brings more flexibility than the deprecated Block parents do.

Implementation

This is implemented via #51

@jissereitsma jissereitsma self-assigned this Jul 14, 2018
@jissereitsma jissereitsma added question Further information is requested debate needed labels Jul 14, 2018
@schmengler schmengler added the on agenda of hangout This issue will be discussed in the next open hangout label Jul 26, 2018
@jissereitsma
Copy link
Contributor Author

This needs to be added to a ruleset.xml specific to Magento 2.2.

@schmengler schmengler added accepted This rule is accepted by extdn and removed debate needed on agenda of hangout This issue will be discussed in the next open hangout question Further information is requested labels Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted This rule is accepted by extdn
Projects
None yet
Development

No branches or pull requests

2 participants