Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Adds azureProperty property to handle backward compatibility when using the isBinary property #495

Conversation

SayakMukhopadhyay
Copy link

Closes #494

@Flydiverny
Copy link
Member

I'm not sure I understand the intent #494 references #311 which talks about property, this is true for all cases of returning binary data from a secret backend (some require isBinary to be set, some can detect automatically).

apiVersion: kubernetes-client.io/v1
kind: ExternalSecret
metadata:
  name: hello-service
spec:
  ...
  data:
    - key: hello-service/credentials
      name: password
      property: password # <--- this is unsupported with `isBinary`
      isBinary: true

I'm not sure what issue or use case you are trying to cover, would be great on you could elaborate.

It's correct that the Azure backend currently doesn't have feature parity with other backends outside of isBinary usage, there's some info in #460 which tries to resolve this allowing property to be used as expected (when not using isBinary)

@Flydiverny
Copy link
Member

Closing this until further discussion takes place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isBinary field does not work with the property field in Azure backend
2 participants