Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite won't build with standard function aliasing on, due to catch #85

Closed
eyalroz opened this issue Jan 21, 2022 · 2 comments
Closed

Test suite won't build with standard function aliasing on, due to catch #85

eyalroz opened this issue Jan 21, 2022 · 2 comments
Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch task testing Only relevant to the testing programs rather than the main code itself

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jan 21, 2022

The catch unit-testing framework includes the C standard library's printf-family functions; consequently, it clashes with our library when we alias the standard printf-family function names. In the past this was circumvented by including printf.c within a namespace, but now that printf.c is more language-aware, that's not possible; plus, it wasn't a good idea, since it was testing something others than what library users will actually be doing.

Anyway, now we have this clash. This means either we need to not run the test suite with the aliased names, or ... do something else?
@eyalroz eyalroz added bug Something isn't working task testing Only relevant to the testing programs rather than the main code itself and removed bug Something isn't working labels Jan 21, 2022
eyalroz added a commit that referenced this issue Jan 21, 2022
@eyalroz
Fixes #85: Only compiling our test suite when standard library functi…
e014090 
…on name aliasing is disabled. For testing aliased functionality, we have a separate test.
@eyalroz eyalroz added the resolved-on-develop A changeset fixing this issue has been commiutted to the development branch label Jan 21, 2022
eyalroz added a commit that referenced this issue Jan 21, 2022
@eyalroz
Fixes #85: Only compiling our test suite when standard library functi…
dd06282 
…on name aliasing is disabled. For testing aliased functionality, we have a separate test.
eyalroz added a commit that referenced this issue Jan 22, 2022
@eyalroz
Fixes #85: Only compiling our test suite when standard library functi…
b9b4bf1 
…on name aliasing is disabled. For testing aliased functionality, we have a separate test.
@phillipjohnston
Copy link

phillipjohnston commented Jan 25, 2022 •
edited
Loading

Huh... I'm not using your build system (libc is using Meson), but I do have aliasing enabled and the tests build for me.

@phillipjohnston
Copy link

I was wrong, looks like that compiler arg isn't applied to the test suite! Sorry for the distraction.

eyalroz added a commit that referenced this issue Jan 26, 2022
@eyalroz
Fixes #85: Only compiling our test suite when standard library functi…
abcd93e 
…on name aliasing is disabled. For testing aliased functionality, we have a separate test.
eyalroz added a commit that referenced this issue Jan 31, 2022
@eyalroz
Fixes #85: Only compiling our test suite when standard library functi…
00685a9 
…on name aliasing is disabled. For testing aliased functionality, we have a separate test.
eyalroz added a commit that referenced this issue Jan 31, 2022
@eyalroz
Fixes #85: Only compiling our test suite when standard library functi…
e853748 
…on name aliasing is disabled. For testing aliased functionality, we have a separate test.
eyalroz added a commit that referenced this issue Jan 31, 2022
@eyalroz
Fixes #85: Only compiling our test suite when standard library functi…
913672e 
…on name aliasing is disabled. For testing aliased functionality, we have a separate test.
eyalroz added a commit that referenced this issue Feb 11, 2022
@eyalroz
Fixes #85: Only compiling our test suite when standard library functi…
7937b8c 
…on name aliasing is disabled. For testing aliased functionality, we have a separate test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch task testing Only relevant to the testing programs rather than the main code itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phillipjohnston @eyalroz