-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use optional kwarg for cols16
accross pywal API
#77
Comments
yeh that will not be the only change needed... since now pywal has the contrast option... so current master's cache_fname looks like this: def cache_fname(img, backend, cols16, light, cache_dir, sat="", contrast=""): while pywal's 3.3.0 cache_fname is: def cache_fname(img, backend, light, cache_dir, sat=""): that would mean slapping both cols16 and contrast into the same **kwargs dict ending up with an heterogeneous dict that contains a truthy string that can be lighten or darken and a float... now in cases like wpgtk it doesn't matter that the pywal16 API is uglier as things such as contrast and 16 colors are implemented inside wpgtk in it's own manner, but for those who want to use the pywal16 specific features OR simply collaborate to the project the codebase will come as more ugly and hard to read than already is, something i wanted to help by not just formatting the code with black but also start adding type annotations across the code, i hate to delay the release of pywal16 further but will have to since i want to both add type annotations and provide a more compatible API for programs using pywal as a library... |
This improves the backwards compatibility of the API. Closes #77
This improves the backwards compatibility of the API. Closes #77
This improves the backwards compatibility of the API. Closes #77
this gives developers freedom in terms of choosing to use this option or not, making a transition between pywal and pywal16 smoother, moreover it adds a bit of consistency between
cache_fname
andcolor.get
.for now I have to do something ugly like:
just to avoid not passing cols16.
The text was updated successfully, but these errors were encountered: