EZP-31325: Added test coverage for sorting by Content & Location IDs #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
alongosz
force-pushed
the
ezp-31325-integration-test-coverage
branch
from
4887ed5 to
0afcc22
Compare
alongosz
changed the title
alongosz
force-pushed
the
ezp-31325-integration-test-coverage
branch
from
3de285a to
f0ae710
Compare
Nattfarinn
approved these changes
Jun 1, 2020
ViniTou
approved these changes
Jun 5, 2020
adamwojs
approved these changes
Jun 5, 2020
micszo
approved these changes
Jul 14, 2020
* Added missing test coverage for sorting by Content IDs and Location IDs of different length (order of magnitude) to check if ordering by integer values works * Fixed Solr test fixtures after fixing sorting bug * Renamed \eZ\Publish\API\Repository\Tests\BaseTest::createContentType to createSimpleContentType to avoid collision with \eZ\Publish\API\Repository\Tests\FieldType\BaseIntegrationTest::createContentType * Improved maintenance of SearchServiceTest::assertQueryFixture
alongosz
force-pushed
the
ezp-31325-integration-test-coverage
branch
from
f0ae710 to
552b6b1
Compare
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.13,7.5,master,ezplatform-kernel:1.0+This PR adds dedicated test coverage for sorting by Content IDs and Location IDs of different length (order of magnitude), to check if ordering by integer values works.
It also fixes other Solr fixtures supporting wrong assumption that Solr results should be different. At the same time DX for working with those tests was improved by producing more verbose message (there's a lot of fixtures).
6.13only: Additionally the PR enforces using Solr Bundle1.5.x-devto run tests against as that version of the Bundle is the newest supporting Solr 4.10 and documented as the one to use with eZ Platform 1.13.Some minor required fixes for the test cases are introduced as well (they're already done on upper branches).
TODO:
$ composer fix-cs).