Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deprecated: preg_replace(): Passing null to parameter #3 ($subject) o… #421

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

nikkii94
Copy link
Contributor

@nikkii94 nikkii94 commented Oct 31, 2024

Fixes deprecation error for "Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated"

…ect) of type array|string is deprecated fix
@nikkii94 nikkii94 changed the title Deprecated: preg_replace(): Passing null to parameter #3 ($subject) o… fix: Deprecated: preg_replace(): Passing null to parameter #3 ($subject) o… Oct 31, 2024
@ezyang
Copy link
Owner

ezyang commented Nov 1, 2024

Do you have a test that exercises this? It seems to be html should never be null

@nikkii94
Copy link
Contributor Author

nikkii94 commented Nov 1, 2024

No, but I found this in my error log multiple times

Copy link
Owner

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not great but whatever

@ezyang ezyang merged commit 5d154a2 into ezyang:master Nov 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants