feat: Add option for safe iframe hosts using array lookup #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elirenato
changed the title
ezyang
reviewed
Nov 7, 2024
ezyang
reviewed
Nov 7, 2024
elirenato
force-pushed
the
add-safe-iframe-hosts-config
branch
from
9b66bca to
d2d87dd
Compare
ezyang
reviewed
Nov 9, 2024
| // check if the host is in a whitelist for safe iframe hosts | ||
| if ($safeHosts !== null && !isset($safeHosts[$uri->host])) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
You know what, I was wrong, disjunction actually seems right 🤣 Because it's a whitelist. So you can whitelist some urls with regex and also whitelist some hosts with safe host...
There was a problem hiding this comment.
No problem. I changed it back. Thanks.
elirenato
force-pushed
the
add-safe-iframe-hosts-config
branch
from
d2d87dd to
93ec6fd
Compare
* Added new option `URI.SafeIframeHosts` to use an array lookup with whitelisted hosts in conjunction to `URI.SafeIframeRegexp`.
ezyang
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thank you for this awesome library.
I would like to know if you would consider adding a new option to use a list of "safe" iframe hosts in addition to SafeIframeRegExp.
I’m also starting to include Docker files to make it easier to bootstrap the development environment. I can remove them if needed.
Thank you