Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toml #30
Toml #30
Changes from all commits
a49bb9f
d6359dc
3d74571
34e2fe8
c2eaa9b
b5d9af9
a29a9f5
5e546d4
6198755
4a262d8
6a262d0
89cdd2b
6d3d682
df8a7af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing
AddressLiteral
togetPlasmaContractAddress
is besically no op why not just do that log here andpure addr'
, and remove theAddressSource
data type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will decide whether or not to do this after we have a more standard setup script. My hope is that we can somehow do a fresh contract deployment / cliquebait for a test suite, but I also want to be able to run it from an existing deployment.
I did it yesterday for a reason I can't recall right now, but will only change it if I'm sure I don't want it. It works for now