Add option to hide animation progress bar #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
reviewed
Jun 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1478 +/- ##
=======================================
Coverage 96.63% 96.64%
=======================================
Files 103 103
Lines 7729 7742 +13
=======================================
+ Hits 7469 7482 +13
Misses 260 260 ☔ View full report in Codecov by Sentry. |
mwestphal
reviewed
Jun 21, 2024
mwestphal
reviewed
Jun 21, 2024
|
@mwestphal Why did the coverage check fail saying that no token has been found? It surely looks like it is unrelated to my changes. |
Indeed unrelated, codecov have some issues not yet fixed: codecov/feedback#112 (comment) |
mwestphal
reviewed
Jun 21, 2024
mwestphal
reviewed
Jun 21, 2024
mwestphal
reviewed
Jun 21, 2024
mwestphal
requested changes
Jun 21, 2024
mwestphal
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added option to hide animation bar as requested in #1465