Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website | Contribution section #249

Merged
merged 3 commits into from
May 14, 2024
Merged

Website | Contribution section #249

merged 3 commits into from
May 14, 2024

Conversation

reb-dev
Copy link
Collaborator

@reb-dev reb-dev commented Aug 5, 2023

This PR adds an official contribution section to our website.

There is still more that could be added, but hopefully this will be a good starting point for developers who want to contribute to the project.

Screenshot 2024-05-08 at 5 17 15 PM

Copy link
Contributor

@rokotyan rokotyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reb-dev Great job! I've left a few comments, but overall I think everything is well written and clear.

I'll start working on the Architecture section once I finish working on the Annotations component.

@rokotyan
Copy link
Contributor

rokotyan commented Nov 9, 2023

@reb-dev Unfortunately, I got locked out earlier than I expected, so I won't be able to push my changes. There was not much, just a short intro and a mermaid diagram of containers, the components they support, and their relationship to the core classes.

@reb-dev reb-dev force-pushed the docs/contibuting branch 3 times, most recently from 41704cb to 96c6406 Compare May 8, 2024 23:58
@reb-dev reb-dev force-pushed the docs/contibuting branch from 96c6406 to feb7d9b Compare May 9, 2024 00:17
@reb-dev reb-dev marked this pull request as ready for review May 9, 2024 00:23
@reb-dev reb-dev requested a review from lee00678 May 9, 2024 00:23
Copy link
Collaborator

@lee00678 lee00678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I left a couple really small comments.

packages/website/contributing/guides/gallery-examples.mdx Outdated Show resolved Hide resolved
packages/website/contributing/guides/gallery-examples.mdx Outdated Show resolved Hide resolved
packages/website/contributing/guides/gallery-examples.mdx Outdated Show resolved Hide resolved
@reb-dev reb-dev force-pushed the docs/contibuting branch from feb7d9b to 3201ea8 Compare May 14, 2024 20:41
Copy link
Collaborator

@lee00678 lee00678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Looks good!

@reb-dev reb-dev merged commit 681f477 into main May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants