Component | Graph: Layout recalculation and persistency fix

[rokotyan]

This PR fixes layout problems reported in #393:

• fixNodePositionAfterSimulation not working correctly in Force Layout
• Layout update when dynamically switching between different layouts

[reb-dev]

@rokotyan I made a demo example to test this, I'm getting strange behavior if any panning/zooming occurs. Should we reset the transform on layout change as well?

Screen.Recording.2024-05-31.at.10.58.39.AM.mov

[lee00678]

@rokotyan I tried to modify one of the gallery example to test this. It seems once the layout changed, the chart no longer fit in the view window.

Screen.Recording.2024-05-31.at.11.21.45.AM.mov

[rokotyan]

@reb-dev @lee00678 Thanks for testing this! I didn't see such behavior in my environment, let me take another look.

[rokotyan]

@reb-dev Can you please push your example to the branch?

[rokotyan]

Thanks @reb-dev

My latest commits should take care of that and also fix #393

[reb-dev]

@rokotyan Testing it again I'm discovering inconsistent behavior with fixNodePositionAfterSimulation.

Currently if you dynamically add data to the graph when it is set to true, the layout doesn't rearrange. When false, it does. However if you switch to force layout type from a different layout with fixNodePositionAfterSimulation set to true, the layout still rearranges on data updates.

Also could you clarify what the expected behavior is for this property?

[rokotyan]

@reb-dev You're right, something wrong is happening when changing the layout. Thanks for catching this, I'll investigate

[rokotyan]

@reb-dev Found the problem and fixed, see the last two commits. Thanks again for testing this thoroughly.

[reb-dev]

Thanks for the updates @rokotyan, looks good to me!