Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev | Examples | Donut chart: Component name fix while launching stac… #420

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

lucky-9
Copy link
Contributor

@lucky-9 lucky-9 commented Jul 25, 2024

When we open https://unovis.dev/gallery/view?collection=Circular%20Charts&title=Basic%20Donut%20Chart for Angular Framework, The stackblitz is not rendering the component.
Screenshot 2024-07-25 at 5 18 43 PM


This PR will fix this issue.

Copy link

github-actions bot commented Jul 25, 2024

CLA Assistant Lite bot ✅ All required contributors have signed the F5 CLA for this PR. Thank you!

@lucky-9
Copy link
Contributor Author

lucky-9 commented Jul 25, 2024

I have hereby read the F5 CLA and agree to its terms

@lee00678
Copy link
Collaborator

lee00678 commented Jul 25, 2024

@lucky-9 nice catch! Thanks for the fix. Could you please finish the required steps for CLA so I can merge this in?

@lucky-9
Copy link
Contributor Author

lucky-9 commented Jul 25, 2024

or CLA so I can merge this i

@lee00678 I am not understanding how to finish the CLA, can you please explain?. I have already commented 'I have hereby read the F5 CLA and agree to its terms' here #420 (comment)

@lucky-9
Copy link
Contributor Author

lucky-9 commented Jul 25, 2024

recheck

@rokotyan
Copy link
Contributor

@lucky-9 You probably need to set your email in git settings locally and redo the commit. It looks like GitHub was not able to identify your account:
image

@lucky-9 lucky-9 force-pushed the basic-donut-chart-component-name-fix branch from 911562c to 7c5bd28 Compare July 26, 2024 04:28
@lucky-9
Copy link
Contributor Author

lucky-9 commented Jul 26, 2024

@rokotyan @lee00678 Done. Please review and merge the code. Thank you

@lee00678 lee00678 merged commit c61925b into f5:main Jul 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants