Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check buttonReverse property in reset method #91

Closed
fabien-d opened this issue Jan 12, 2013 · 2 comments
Closed

Check buttonReverse property in reset method #91

fabien-d opened this issue Jan 12, 2013 · 2 comments

Comments

@fabien-d
Copy link
Owner

The reset method in the addListeners method needs to take the buttonReverse property into account when resetting the focus. If button are reversed, btnOK and btnCancel should be reversed.

reset = function (event) {
    if (hasInput) input.focus();
    else if (hasCancel) btnCancel.focus();
    else btnOK.focus();
};
fabien-d added a commit that referenced this issue Apr 20, 2013
fabien-d added a commit that referenced this issue Apr 20, 2013
@fabien-d
Copy link
Owner Author

Merged. Issue resolved in 0.3.9. Branch 0.3 of repo or can be downloaded for the demo site.

Leaving opening because it's still an issue for 0.4.

@fabien-d
Copy link
Owner Author

0.4 is deprecated - closing

psolom pushed a commit to psolom/alertify.js that referenced this issue Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant