Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolving dialog blocking elements #93

Merged
merged 1 commit into from
Jan 12, 2013
Merged

resolving dialog blocking elements #93

merged 1 commit into from
Jan 12, 2013

Conversation

fabien-d
Copy link
Owner

Resolves

Notes

  • Moved common elements to be fetch only once per dialog (buttons, form, input)
  • Fixed transitionend events
  • Create common setFocus private method instead of repeating code
  • Hide dialog after fading out (fixing the raised issue)
  • Replaced IE7-8 CSS hack. Turns out IE10 reads it \9.

fabien-d added a commit that referenced this pull request Jan 12, 2013
@fabien-d
Merge pull request #93 from fabien-d/hideDialog-92
a3ab8f9 
resolving dialog blocking elements
@fabien-d fabien-d merged commit a3ab8f9 into master Jan 12, 2013
@fabien-d fabien-d deleted the hideDialog-92 branch January 12, 2013 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fabien-d