Add Macos to CI tests

fabiencelier · Nov 6, 2019 · 0d8ab84 · 0d8ab84
1 parent 6d2f382
commit 0d8ab84
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -12,7 +12,7 @@ jobs:
     strategy:
       matrix:
         python-version: ["3.7", "3.8"]
-        os: ["ubuntu-latest"] # add 'macOS-latest' once support for Python 3.8 is ready # add "windows-latest" when possible
+        os: ["ubuntu-latest", "macOS-latest"] # add "windows-latest" when possible
     runs-on: ${{ matrix.os }}
     name: Testing - Python ${{ matrix.python-version }} - ${{ matrix.os }}
     steps:
@@ -21,12 +21,15 @@ jobs:
         with:
           python-version: ${{ matrix.python-version }}
           architecture: "x64" # (x64 or x86)
-      - if: matrix.os == 'ubuntu-latest'
-        name: Install pipenv
+      - if: matrix.os == "ubuntu-latest"
+        name: Install pipenv Linux
         run: sudo pip3 install pipenv
-      - if: matrix.os == 'windows-latest'
-        name: Install pipenv
+      - if: matrix.os == "windows-latest"
+        name: Install pipenv Windows
         run: pip install pipenv
+      - if: matrix.os == "macOS-latest"
+        name: Install pipenv MacOS
+        run: brew install pipenv
       - name: Install python dependencies
         run: pipenv install --dev --python ${{ matrix.python-version }}
       - name: Formatting check with black

diff --git a/test/test_cli.py b/test/test_cli.py
@@ -9,8 +9,3 @@ def test_cli_help():
     assert str(output, encoding="utf-8").startswith("usage: universions")
     output = check_output(["universions", "--help"])
     assert str(output, encoding="utf-8").startswith("usage: universions")
-
-
-def test_cli_help():
-    output = check_output(["universions", "java"])
-    assert str(output, encoding="utf-8").startswith("usage: universions")