HTTP2 Pusher interface is broken #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 91aebaa into 1945d0d - view on LGTM.com fixed alerts:
|
fabiocicerchia
force-pushed
the
issue-33
branch
from
91aebaa to
bd31937
Compare
|
This pull request fixes 1 alert when merging bd31937 into 1945d0d - view on LGTM.com fixed alerts:
|
fabiocicerchia
force-pushed
the
issue-33
branch
25 times, most recently
from
049ace2 to
6f030e4
Compare
fabiocicerchia
force-pushed
the
issue-33
branch
12 times, most recently
from
73ae33f to
cea31d3
Compare
fabiocicerchia
force-pushed
the
issue-33
branch
3 times, most recently
from
92f923c to
8ab5458
Compare
fabiocicerchia
force-pushed
the
issue-33
branch
from
8ab5458 to
b9ed588
Compare
fabiocicerchia
force-pushed
the
issue-33
branch
5 times, most recently
from
1a09133 to
ae71dcd
Compare
fabiocicerchia
commented
Dec 18, 2020
| @@ -0,0 +1,70 @@ | |||
| # TESTING PURPOSES ONLY | |||
There was a problem hiding this comment.
code smell, should be only one file
| @@ -0,0 +1,4 @@ | |||
| FROM nginx:1.19.5-alpine | |||
There was a problem hiding this comment.
code smell, should be configured in github actions
| @@ -0,0 +1,31 @@ | |||
| map $http_upgrade $connection_upgrade { | |||
There was a problem hiding this comment.
code smell, should be only one file
fabiocicerchia
force-pushed
the
issue-33
branch
from
e69b3ab to
e4c7a2b
Compare
fabiocicerchia
force-pushed
the
issue-33
branch
from
e4c7a2b to
f70fffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #33