Skip to content

Commit

Permalink
changelog: mention #663 and #664
Browse files Browse the repository at this point in the history
Signed-off-by: Pires <[email protected]>
  • Loading branch information
pires committed Jun 14, 2019
1 parent f674828 commit 6f4da87
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,28 @@
Thanks to [@pschultz](https://github.com/pschultz) and
[@leprechau](https://github.com/leprechau) for the debugging and patch.

* [PR #664](https://github.com/fabiolb/fabio/issues/664): Clean-up fabio service entries in Consul on dirty exit

In the case fabio dies abruptly, the steps to deregister any fabio-related
services in Consul will **not** take place.

In most cases, Consul will fail the fabio health check, mark the service as
unhealthy and delete it after `registry.consul.register.deregisterCriticalServiceAfter`
elapses.

However, in certain cases, for instance, where an automated recovery is in
place, the new instance of fabio could take over the same IP:port pair and
Consul would never fail the previous existing health check, meaning Consul
would now have duplicated service and respective check entries, or more
depending on how many times fabio as exited abruptly and was restarted.

This PR addresses this issue by registering a TTL check that is refreshed by
fabio

This PR also introduces missing documentation for the `registry.consul.register.deregisterCriticalServiceAfter` option.

Thanks to [@pires](https://github.com/pires) for the [report](https://github.com/fabiolb/fabio/issues/663) and the fix.

#### Bug Fixes

* [PR #577](https://github.com/fabiolb/fabio/pull/577): Fix ip access rules within tcp proxy
Expand Down

0 comments on commit 6f4da87

Please sign in to comment.