Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar of the website is a little off #599

Closed
mildred opened this issue Jan 31, 2019 · 2 comments · Fixed by #606
Closed

Sidebar of the website is a little off #599

mildred opened this issue Jan 31, 2019 · 2 comments · Fixed by #606

Comments

@mildred
Copy link

mildred commented Jan 31, 2019

https://fabiolb.net/

"Features" is partly hidden on Firefox.

image
@pschultz
Copy link
Member

I cannnot reproduce this on Firefox 65. Are you sure you had scrolled all the way up before taking the screenshot?

@mildred
Copy link
Author

mildred commented Feb 28, 2019

Yes, but I checked again, and I cannot reproduce it with JavaScript enabled. However with JavaScript disabled, I have this problem.

pschultz added a commit that referenced this issue Mar 1, 2019
@pschultz
docs: fix layout without JS enabled
35103f8 
The Bootstrap stylesheet for the website sets the header to position:
fixed, taking it out of the layout flow. Some javascript later updates
the style attribute, so that the content is pushed down by an
appropriate amount.

If JS is disabled that correction doesn't happen, and so the header
overlaps the content.

Make the header static by default, and only apply position: fixed if
JavaScript is enabled.

Fixes #599

Signed-off-by: Peter Schultz <[email protected]>
@pschultz pschultz mentioned this issue Mar 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix layout without JS enabled fabiolb/fabio
2 participants
@mildred @pschultz