Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log.routes.format is broken with 1.5.13 #737

Closed
scalp42 opened this issue Dec 17, 2019 · 7 comments · Fixed by #749
Closed

log.routes.format is broken with 1.5.13 #737

scalp42 opened this issue Dec 17, 2019 · 7 comments · Fixed by #749
Milestone

Comments

@scalp42
Copy link

scalp42 commented Dec 17, 2019

Hi folks,

Using log.routes.format = all, the Fabio logs appear to be broken:

Dec 17 19:10:04 fabio-i-0ec2ac85dcac2e3f1 fabio[23101]: 2019/12/17 19:10:04 [INFO] Updated config to
Dec 17 19:10:04 fabio-i-0ec2ac85dcac2e3f1 fabio[23101]: 2019/12/17 19:10:04 [INFO] Updated config to
Dec 17 19:10:07 fabio-i-0ec2ac85dcac2e3f1 fabio[23101]: 2019/12/17 19:10:07 [INFO] Updated config to

Changing to log.routes.format = delta, it doesn't actually show anything at all in logs.

Only log.routes.format = detail seems to work now.

Thanks in advance

@aaronhurt
Copy link
Member

@scalp42 Thank you for the report. I'll try and take a look at this over the break.

@aaronhurt
Copy link
Member

Taking a TODO here. Sorry again for the delay.

@scalp42
Copy link
Author

scalp42 commented Jan 27, 2020

Please don't be sorry, @leprechau you're appreciated 🙌

@aaronhurt
Copy link
Member

@scalp42 digging into this now, I'll let you know what I find.

@aaronhurt
Copy link
Member

So, I see what's happening. The next and last variables aren't being set. They're empty when passed to the logger. I'm guessing this has something to do with the change to using a buffer instead of string concatenation for the routing table.

I don't know why it's happening yet, but I at least know where to look and can reproduce the problem. This also affects current master branch.

@aaronhurt
Copy link
Member

Thank you for your patience @scalp42, this fix will be included in the next release.

@scalp42
Copy link
Author

scalp42 commented Jan 31, 2020

@leprechau thank you again for the fix, it's much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants