Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve forward headers #98

Closed
magiconair opened this issue May 9, 2016 · 0 comments
Closed

Improve forward headers #98

magiconair opened this issue May 9, 2016 · 0 comments
Labels
enhancement
Milestone
1.1.3

Comments

@magiconair
Copy link
Contributor

The X-Forwarded-For header is currently not set for websocket connections which is probably a regression of #72.

The X-Forwarded-Proto header should be set to ws and wss for websocket connections.

The X-Forwarded-Port header should be set to complete the X-Forwarded-* headers.

The Forwarded header should set proto to either ws or wss for websocket connections.
@magiconair magiconair changed the title Improve headers Improve forward headers May 9, 2016
magiconair added a commit that referenced this issue May 9, 2016
@magiconair
Issue #98: Improve forward headers
6a95ed8 
* The X-Forwarded-For header is currently not set for websocket
  connections which is probably a regression of #72.

* The X-Forwarded-Proto header should be set to ws and wss for
  websocket connections.

* The X-Forwarded-Port header should be set to complete the
  X-Forwarded-* headers.

* The Forwarded header should set proto to either ws or wss
  for websocket connections.
@magiconair magiconair mentioned this issue May 9, 2016
Closed
@magiconair magiconair added this to the 1.1.3 milestone May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1.3
Development

No branches or pull requests
1 participant
@magiconair