Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go's net.JoinHostPort which will auto-detect ipv6 #167

Merged
merged 1 commit into from
Sep 27, 2016
Merged

Use Go's net.JoinHostPort which will auto-detect ipv6 #167

merged 1 commit into from
Sep 27, 2016

Conversation

jovandeginste
Copy link
Contributor

@jovandeginste jovandeginste commented Sep 27, 2016

Without this, fabio will use the ipv6 ip as-is; it should however add square brackets ([]).

Now it registers as follows:

route add svca-a /svc-a http://[2a02:x:x::1]:8180/ tags "www,urlprefix-/svc"

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2016

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@magiconair magiconair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magiconair magiconair merged commit 90d0ca1 into fabiolb:master Sep 27, 2016
@magiconair magiconair added this to the 1.3.3 milestone Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants