#429 issue - OpenTrace zipKin Support

[galen0624]

"OpenTracing zipKin Support. Reference - Issue #429

Co-authored-by: Jeremy White [email protected]
Co-authored-by: Kristina Fischer [email protected]
Co-authored-by: Michael Murphy [email protected]
Co-authored-by: Nathan West [email protected]
Co-authored-by: Austin Hartzheim [email protected]
Co-authored-by: Jacob Hansen [email protected]"

[kmfischer3]

@magiconair We are working on fixing the Travis CI build, cleaning up the tracing code, and adding tests.

[galen0624]

@magiconair Any thoughts on this PR? Should we continue to work on this or should we go in a different direction?

[magiconair]

Sorry, I just started a new job traveling between Amsterdam and Stockholm. I'll try to find some time to review this but I'd love to merge this.

[CLAassistant]

All committers have signed the CLA.

[kmfischer3]

@magiconair We have added some tests for the tracing feature. Please let us know if there are any changes needed before this gets merged.

[magiconair]

@kmfischer3 Sorry for the delay. Catching my breath after moving countries. Could you please rebase so that I can merge this? Thank you

[galen0624]

@magiconair I rebase lined this PR with the current 1.5.10 release.

[magiconair]

Thank you.

[andrej-urvantsev]

I know that issue is closed but it looks that one must provide host and port of zipkin server in order to push spans there.

Will it be possible to use service discovery instead of that?
So you can provide tracing.connectString="http://zipkin-service" where zipkin-service is a service name in Consul instead of http:port pair?