Add setting to flush fabio buffer regardless headers #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
samm-git
force-pushed
the
add-global-flush
branch
from
a77c035 to
f10db85
Compare
samm-git
force-pushed
the
add-global-flush
branch
from
fc15b37 to
96f2aa7
Compare
|
LGTM. Could you also please add an entry to the website docs? https://github.com/fabiolb/fabio/tree/master/docs/content/ref Thx |
|
@magiconair hi, thank you for review! it is already in this PR if i understand you properly - https://github.com/fabiolb/fabio/pull/531/files#diff-b10f488af9bd0792cae6f6d2280472dc |
|
@magiconair hi, do you have any updates? Would be great to see it merged. |
|
@magiconair ping again :) |
|
@magiconair any chance to see it merged? |
|
@samm-git Thank you for your patience. I see the docs. LGTM! Thank you! |
|
@samm-git thx for your patience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds ability to configure flush buffer interval for non-SSE request.
In my configuration Fabio is serving services behind CDN. CDN expects any response to start (TTFB) within preconfigured timeout and if it is not - responds with 504. I can workaround this with setting SSE header, but in this case flush time is just 1s and also it requires to control every client which doing requests, and it is not always possible. This PR adds another setting, which can set this timeout globally, for all non-SSE requests. I am planning to set it to value which is high enough to not have significant performance impact but lower then cdn timeout.