fix exit status code #637
Merged
fix exit status code #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabio always returned status code 1. Event on clean exit. Shutdown of http server is treated as fatal: [FATAL] http: Server closed [FATAL] ui: http: Server closed Http server Serve method always returns non nil error: https://golang.org/pkg/net/http/#Server.Serve ErrServerClosed should be treated as clean exit. "After Shutdown or Close, the returned error is ErrServerClosed."
|
|
|
Looks good to me, but this should be clearly communicated in the changelog. It's conceivable that some people run fabio under a supervisor that only restarts on non-zero exit (I believe systemd can be made to behave like that), and this change may cause fabio to not be always restarted anymore. |
|
agreed, good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fabio always returned status code 1. Even on clean exit.
Shutdown of http server is treated as fatal:
HTTP server Serve method always returns non nil error.
ErrServerClosed should be treated as clean exit.