Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement clickable source links in ui #906

Closed
wants to merge 1 commit into from

Conversation

Kamilcuk
Copy link
Contributor

Feature request: Make source links in ui interface clickable #901

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2022

CLA assistant check
All committers have signed the CLA.

@Kamilcuk
Copy link
Contributor Author

obraz

<a href="http://localhost/product">/product</a>
<a href="http://localhost/product">/product</a>
<a href="http://httpsrc.com:443/">httpsrc.com:443/</a>
<a href="http://httpssrc.com:80/">httpssrc.com:80/</a>
<a href="http://www.dba.dev/auth/">www.dba.dev/auth/</a>

@KTruesdellENA
Copy link
Contributor

Reviewed, discussed this and made some changes to this and made this an option to be set in the *.properties file or the cli configuration. It would default to not being enabled, but can be enabled.
Added in some options with that as well to be able to set a different protocol scheme, host, or port for these links or default to the current server address (for those links that are a subdirectory).
Also, added another option to have links open in a new tab and defaulted to a new window.

Going to branch your commit and merge things for this PR. Then you can review and see if it meets your needs.

@Kamilcuk
Copy link
Contributor Author

Kamilcuk commented Oct 3, 2022

Closing because #907 is there.

@Kamilcuk Kamilcuk closed this Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants