Replaced initEvent to new Event #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[initEvent](https://developer.mozilla.org/en-US/docs/Web/API/Event/initEvent) is no longer recommended. The standard is `new Event` or `new MouseEvent` instead of `document.createEvent` + `event.initEvent`
cyfung1031
added a commit
to cyfung1031/jquery-cash
that referenced
this pull request
May 3, 2023
As per introduction of `WeakMap` in fabiospampinato#423 and dropped `initEvent` with IE11 in fabiospampinato#422.
|
Thank you, as this is a change with brings no benefits (there's loads of deprecated web stuff which will never be removed), I'd rather not take the risk and merge something which maaaaaybe may have some unforeseen changes, since the premise is that ideally this should basically work the same way anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initEvent is no longer recommended.
The standard is
new Eventornew MouseEventinstead ofdocument.createEvent+event.initEventThere shall be no compatible issue since IE11+ dropped.
API docs: new Event & new MouseEvent
Chrome 26+, Edge 12+, Firefox 11+, Opera 15+, Safari 7+