-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update margins for Cameo 1 #316
base: main
Are you sure you want to change the base?
Conversation
Offset for Cameo 1 was too high previously, as e.g. discussed in fablabnbg#15
@tiger12506 can you give your review in this PR? |
Okay, I'm not sure I can follow... For me, my patch makes (0,0) appear at (0,0) on the cutting mat with (0mm, 0mm) user-configurable offset. Are you saying it only is correct for you when you use a (2mm, 5mm) offset? I'd like to not worry about the bottom (yet), as that is a different problem and I'm not sure about your test procedure. Things to check:
|
I just tried cutting at exactly (0,0) and it only cut the two inner lines of the square. If the square is moved ever so slightly, it works. And cutting at exactly 12 in x or y is the same, doesn't work. But ever so slightly moved inwards, it works. So I can say for sure that no problem in proportion to the length of cut exists on my machine. The squares are cut exactly were I placed them digitally. This is what I wanted to solve with this PR. Could you please confirm again? I know for some cuts near the edge things can be annoying, but that is out of the scope of this PR I think and it's already quite an improvement. |
Yes, but for me the offset really isn't the issue at all. Think about it, you can manually place the cutting mat in slightly different positions, and your offset would be wrong. Unless we are getting out the calipers and carefully placing our mats the exact same position from the endstops, we will never determine a "correct" offset.
No, user offset set to 0mm, 0mm is off the mat for me (again, might be a cricut mat issue. Not my concern)
Yes, I sent the svg. There are 4 squares, (0,0) -> (10mm,10mm), (12in-10mm,0) -> (12in,10mm), (12in-10mm, 0) -> (12in, 10mm), (12in-10mm, 12in-10mm) -> (12in, 12in)
I think so... would have to check.
To some extent, yes, but I believe there to be a bug regardless. Silhouette Studio by default will have margins on a 12inx12in cutting mat, but you can change the preference to have no margins, and it works. My issue with inkscape-silhouette is that clipping is happening in a way that doesn't respect the offset at all. Sure, if you had (0,0) user offset, then it would work correctly (I cannot actually confirm this as (0,0) is outside the working area of the mat for me)-- it would just be in the wrong place. Thus defeating the purpose of the offset entirely. So, the issue is not that the offset is wrong. The issue is that applying an offset (that I need) cannot produce a valid result (for me). I will need to run the tests again. |
@tiger12506 @miLORD1337 in case it's hard to explain the settings you apply for that use case:
Hope this helps to clarify soon with this |
Offset for Cameo 1 was too high previously, as e.g. discussed in #15