Add back base Union/Record classes #2194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to compile Fable.SimpleJson with Nagareyama we realized the code that relied on Unions and Record inheriting some behavior (like
toJSON
implementations) could easily break so I've tried to apply @chrisvanderpennen solution (see #2160) to bring back the base classes for unions and records ...although it seems @Zaid-Ajaj already managed to fix Fable.SimpleJson so maybe this is already outdate 😅Zaid-Ajaj/Fable.SimpleJson#54
In microbenchmarks initializing derived classes takes longer, but I couldn't see an appreciable difference when running the benchmark (see #2186) between this branch and current
nagareyama
.