fix: enabling exit codes for general cli o/p and updating field names #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzainee-zz
requested changes
Apr 8, 2021
There was a problem hiding this comment.
Please also fix the spelling in
cli-tools/analyses/summary/types.go
Line 15 in 5254513
Change needed: vulnerabilites -> vulnerabilities
arajkumar
reviewed
Apr 8, 2021
added 2 commits
April 8, 2021 12:17
arajkumar
reviewed
Apr 8, 2021
analyses/verbose/types.go
Outdated
| @@ -29,7 +29,7 @@ type DependenciesType struct { | |||
| Transitives []DependenciesType `json:"transitives"` | |||
| LatestVersion string `json:"latest_version"` | |||
| RecommendedVersion string `json:"recommended_version"` | |||
| CommonlyKnownVulnerabilities []VulnerabilityType `json:"commonly_known_vulnerabilities"` | |||
| CommonlyKnownVulnerabilities []VulnerabilityType `json:"publicly_available_vulnerabilities"` | |||
There was a problem hiding this comment.
Should we change the field name as well? @yzainee ?
CommonlyKnownVulnerabilities => PubliclyAvailableVulnerabilities?
There was a problem hiding this comment.
it wouldnt matter much in the end. will leave it to @deepak1725
There was a problem hiding this comment.
@arajkumar its internal usage only.. I feel it's okay to keep it as it is.
Please let me know if you have strong opinions regarding that.
There was a problem hiding this comment.
Anyway, included that update also
CommonlyKnownVulnerabilities => PubliclyAvailableVulnerabilities?
yzainee-zz
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling exit codes for general CLI output and updating field names
Jira: https://issues.redhat.com/browse/APPAI-1816