Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add crda config commands #50

Merged
merged 2 commits into from
Apr 26, 2021

Conversation

deepak1725
Copy link
Member

@deepak1725 deepak1725 commented Apr 23, 2021

  • Adding CRDA Config Commands
    - crda config set CONFIG-KEY Value
    - crda config get CONFIG-KEY

  • Telemetry: Collecting Ecosystem value

  • Telemetry: Moving Prompt to subcommand level

  • Telemetry: Embedding RH Telemetry Info link (https://developers.redhat.com/article/tool-data-collection)

  • Updating ReadMe to point to the version latest release

  • Updating ReadMe to add Telemetry Info.

  • Adding Prod Segment Key to Releaser Job

@deepak1725 deepak1725 self-assigned this Apr 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2021

Codecov Report

Merging #50 (1d5f882) into main (caeee8f) will decrease coverage by 1.58%.
The diff coverage is 7.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   37.50%   35.91%   -1.59%     
==========================================
  Files          20       23       +3     
  Lines         784      827      +43     
==========================================
+ Hits          294      297       +3     
- Misses        462      502      +40     
  Partials       28       28              
Impacted Files Coverage Δ
cmd/analyse.go 10.63% <0.00%> (-0.48%) ⬇️
cmd/auth.go 3.33% <0.00%> (-0.06%) ⬇️
cmd/root.go 6.25% <0.00%> (+0.50%) ⬆️
pkg/telemetry/telemetry.go 7.14% <0.00%> (-1.37%) ⬇️
cmd/get.go 5.88% <5.88%> (ø)
cmd/set.go 5.88% <5.88%> (ø)
cmd/config.go 25.00% <25.00%> (ø)
pkg/segment/segment.go 22.58% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caeee8f...1d5f882. Read the comment docs.

@deepak1725 deepak1725 added this to the v0.2.0 milestone Apr 23, 2021
prashbnair
prashbnair previously approved these changes Apr 26, 2021
@deepak1725 deepak1725 merged commit 4bc0b72 into fabric8-analytics:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants