Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating env variables to Prepend crda #67

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

deepak1725
Copy link
Member

Prepending Config variables with crda

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #67 (910f355) into main (b91c34b) will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   35.47%   35.47%           
=======================================
  Files          24       24           
  Lines         857      857           
=======================================
  Hits          304      304           
  Misses        524      524           
  Partials       29       29           
Impacted Files Coverage Δ
cmd/analyse.go 9.80% <0.00%> (ø)
cmd/auth.go 3.12% <0.00%> (ø)
cmd/root.go 5.95% <0.00%> (ø)
pkg/config/viper_config.go 77.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91c34b...910f355. Read the comment docs.

@yzainee-zz
Copy link
Member

LGTM. @sawood14012 approve once you are satisfied with the tests

Copy link
Member

@sawood14012 sawood14012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepak1725 deepak1725 merged commit 734eec0 into fabric8-analytics:main Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants