fix: potential NPE in EnsureSIngleStorageVersionDecorator

fabric8io · May 19, 2021 · 76e1762 · 76e1762
1 parent 45cfa83
commit 76e1762
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.../main/java/io/fabric8/crd/generator/v1/decorator/EnsureSingleStorageVersionDecorator.java b/.../main/java/io/fabric8/crd/generator/v1/decorator/EnsureSingleStorageVersionDecorator.java
@@ -40,7 +40,7 @@ public void andThenVisit(CustomResourceDefinitionSpecFluent<?> spec, ObjectMeta
     }
 
     for (CustomResourceDefinitionVersion version : spec.buildVersions()) {
-      if (version.getStorage()) {
+      if (version.getStorage() != null && version.getStorage()) {
         String existing = storageVersion.get();
         if (existing != null && !existing.equals(version.getName())) {
           throw new IllegalStateException(String.format(

diff --git a/.../java/io/fabric8/crd/generator/v1beta1/decorator/EnsureSingleStorageVersionDecorator.java b/.../java/io/fabric8/crd/generator/v1beta1/decorator/EnsureSingleStorageVersionDecorator.java
@@ -41,7 +41,7 @@ public void andThenVisit(CustomResourceDefinitionSpecFluent<?> spec, ObjectMeta
     }
 
     for (CustomResourceDefinitionVersion version : spec.buildVersions()) {
-      if (version.getStorage()) {
+      if (version.getStorage() != null && version.getStorage()) {
         String existing = storageVersion.get();
         if (existing != null && !existing.equals(version.getName())) {
           throw new IllegalStateException(String.format(